OK, I worked on the collision detection of the walls. How is this? Better? Next up: Working on the jumping.

Yes, the movement and collision are a LOT smoother, good job. :)

I did notice that it's very easy to fall off the top of the little wall parts sticking out, perhaps a bit *too* easy. Also, after touching the end door, collision detection stopped working on the sprites and I could jump through some of the lower ceilings.

(post edited)

OK, I can't come up with a good jumping code, so I'm asking you guys. What should I do about this? I've changed the code around so the walking animation is back, but I have removed the jumping code.

Crashes for me in Mednafen, not sure if it's the emulator.

That's odd, it works fine in Reality Boy.

Wait, nevermind... Something odd is going on on my side. Time to reboot I guess, sorry for the false alarm.

Edit: pretty good. There's something about the animation that makes the movement speed seems like it's varying, though. Not sure what causes it, maybe his back moving like it does.

As for jumping, something like this works decently (very much pseudo code):



Sorry for not having checked your .c file yet, if it's obvious.

Also, the above system is VERY simple, not taking into account for pixel-perfect collision detection. You need a bit more for that (and to avoid your character getting stuck in the floor), but I'm sure you can figure it out from here. :)


EDIT: just checked the code... It's a pretty big mess of if conditions I see. You can at least make the engine itself a bit more efficient by using "else if"s where appropriate.

Example:

Why is this more efficient? Well, if the first if ran, we already know that all other related conditions WILL be false (if x < 0 we know it can't be 0 or higher). Thus the engine doesn't actually NEED to check these extra conditions, and an else if / else in the code WILL actually skip them for you. That's less checking and code execution per frame. ;)

DaVince, your code seemed to be missing stuff. Looking at the code, it looks like the y distance would increase by 1 acceleration unit whenever speed = 0. I think this would work better.



Once again, untested code.

Could be beneficial to check to make sure y_dist is within range for the original if statement. If you are outside of the possible range a y could be, then you have to error handle. But this was intentionally left out.

This code assumes ground is 0, and you jump in the positive y direction.

A more realistic feel would include checking how long the button was held for to adjust the length of the jump, which is not included in the above code.

I have not looked at the game's C code either, or even tried out the game. I will get around to it sometime, just been busy.

Yeah, I did it really quickly to give just a push in the right direction, so there's bound to be things missing. :P You're right about that part, but it could be avoided simply by not adding to the yspeed (or velocity, in your case) at all when he's on the floor (or one pixel above it, anyway).